Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for base_score in _get_attributes function (replace #626) #637

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Aug 1, 2023

No description provided.

tolleybot and others added 2 commits May 24, 2023 17:11
…o float

Signed-off-by: Donald Tolley <tolleybot@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre merged commit 8a0a683 into onnx:main Aug 1, 2023
14 checks passed
xadupre added a commit that referenced this pull request Oct 2, 2023
* Check if base_score is available and it is a string type convert it to float (#637)

Signed-off-by: Donald Tolley <tolleybot@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Co-authored-by: Donald Tolley <tolleybot@gmail.com>
Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* signed (#639)

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* Bump ONNX 1.14.1 in CI pipelines (#644)

* verify onnx 1.14.1 rc2

Signed-off-by: jcwchen <jacky82226@gmail.com>

* Bump ONNX 1.14.1

Signed-off-by: jcwchen <jacky82226@gmail.com>

---------

Signed-off-by: jcwchen <jacky82226@gmail.com>
Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* fix (dev): Working start to address issue #648. This will help enable saving and reading of models from Spark, a requirement for GBTClassifier tree conversion

Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* feat: Allow conversions of SparkML models to ONNX using cluster mode

Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* fix: fix bug that did not fully create temp paths

Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* fix: reformat style

Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

* fix: Fixed formatting style to pass ruff tests

Signed-off-by: James Cao <james.cao@ironwoodcyber.com>

---------

Signed-off-by: Donald Tolley <tolleybot@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: James Cao <james.cao@ironwoodcyber.com>
Signed-off-by: jcwchen <jacky82226@gmail.com>
Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Donald Tolley <tolleybot@gmail.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants